Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(llama-index): add attribute to span for llm request type in dispatcher wrapper #2141

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix(llama-index): add attribute to span for llm request type in dispatcher wrapper #2141

merged 1 commit into from
Oct 15, 2024

Conversation

doronkopit5
Copy link
Contributor

@doronkopit5 doronkopit5 commented Oct 15, 2024 •
edited
Loading

Set LLM_REQUEST_TYPE attribute to span for tracking chat requests. This change ensures proper monitoring and categorization. (#XYZ-123)

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@doronkopit5
Add attribute to span for LLM request type in dispatcher wrapper
828fbca 
Set LLM_REQUEST_TYPE attribute to span for tracking chat requests. This change ensures proper monitoring and categorization. (#XYZ-123)
@doronkopit5 doronkopit5 marked this pull request as ready for review October 15, 2024 11:07
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. python Pull requests that update Python code testing labels Oct 15, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 15, 2024
@doronkopit5 doronkopit5 merged commit c5ef6e0 into main Oct 15, 2024
9 checks passed
@doronkopit5 doronkopit5 deleted the dk/fix_llama_index_span_attribute branch October 15, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doronkopit5 @nirga